Commit 2f441b92 authored by Chris Fritz's avatar Chris Fritz Committed by Evan You

feat: set file basename to __file in production (#1368)

parent fe91c8b6
...@@ -170,10 +170,15 @@ var component = normalizer( ...@@ -170,10 +170,15 @@ var component = normalizer(
code += `\n` + genHotReloadCode(id, hasFunctional, templateRequest) code += `\n` + genHotReloadCode(id, hasFunctional, templateRequest)
} }
// Expose filename. This is used by the devtools and vue runtime warnings. // Expose filename. This is used by the devtools and Vue runtime warnings.
if (!isProduction) { code += `\ncomponent.options.__file = ${
code += `\ncomponent.options.__file = ${JSON.stringify(rawShortFilePath)}` isProduction
} // For security reasons, only expose the file's basename in production.
? JSON.stringify(filename)
// Expose the file's full path in development, so that it can be opened
// from the devtools.
: JSON.stringify(rawShortFilePath)
}`
code += `\nexport default component.exports` code += `\nexport default component.exports`
// console.log(code) // console.log(code)
......
...@@ -46,7 +46,7 @@ test('inherit queries on files', done => { ...@@ -46,7 +46,7 @@ test('inherit queries on files', done => {
}) })
}) })
test('expose filename', done => { test('expose file path as __file outside production', done => {
mockBundleAndRun({ mockBundleAndRun({
entry: 'basic.vue' entry: 'basic.vue'
}, ({ module }) => { }, ({ module }) => {
...@@ -55,6 +55,21 @@ test('expose filename', done => { ...@@ -55,6 +55,21 @@ test('expose filename', done => {
}) })
}) })
test('expose file basename as __file in production', done => {
const origNodeEnv = process.env.NODE_ENV
process.env.NODE_ENV = 'production'
mockBundleAndRun(
{
entry: 'basic.vue'
},
({ module }) => {
expect(module.__file).toBe('basic.vue')
process.env.NODE_ENV = origNodeEnv
done()
}
)
})
test('source map', done => { test('source map', done => {
bundle({ bundle({
entry: 'basic.vue', entry: 'basic.vue',
......
This diff is collapsed.
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment