Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
V
vue-loader
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
pi-plusplus
fork-from-github
vue-loader
Commits
d3e3f5e2
Commit
d3e3f5e2
authored
Mar 23, 2018
by
Evan You
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix: avoid babel options validation error (fix #1209)
parent
8d93672c
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
28 additions
and
1 deletion
+28
-1
plugin.js
lib/plugin.js
+8
-1
edgeCases.spec.js
test/edgeCases.spec.js
+20
-0
No files found.
lib/plugin.js
View file @
d3e3f5e2
...
...
@@ -138,8 +138,15 @@ function cloneRule (rule, normalizedRule) {
return
res
}
// Some loaders like babel-loader passes its own option directly to babel
// and since babel validates the options, "ident" would cause an unknown option
// error. For these loaders we'll bail out on the ident reuse.
const
reuseIdentBlackList
=
/babel-loader/
// Reuse options ident, so that imports from within css-loader would get the
// exact same request prefixes, avoiding duplicated modules (#1199)
function
reuseIdent
(
use
)
{
if
(
use
.
ident
)
{
if
(
use
.
ident
&&
!
reuseIdentBlackList
.
test
(
use
.
loader
)
)
{
use
.
options
.
ident
=
use
.
ident
delete
use
.
ident
}
...
...
test/edgeCases.spec.js
View file @
d3e3f5e2
...
...
@@ -56,3 +56,23 @@ test('test-less oneOf rules', done => {
}
},
res
=>
assertComponent
(
res
,
done
))
})
test
(
'babel-loader inline options'
,
done
=>
{
mockBundleAndRun
({
entry
:
'basic.vue'
,
module
:
{
rules
:
[
{
test
:
/
\.
js/
,
loader
:
'babel-loader'
,
options
:
{
babelrc
:
false
,
presets
:
[
[
require
(
'babel-preset-env'
),
{
modules
:
false
}]
]
}
}
]
}
},
res
=>
assertComponent
(
res
,
done
))
})
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment